Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear error message when the charge got rejected #1923

Merged
merged 26 commits into from
Feb 8, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Feb 8, 2022

closes #1922


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Feb 8, 2022

@render
Copy link

render bot commented Feb 8, 2022

@render
Copy link

render bot commented Feb 8, 2022

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Feb 8, 2022
@Tbaut Tbaut requested a review from FSM1 February 8, 2022 14:06
@Tbaut
Copy link
Collaborator Author

Tbaut commented Feb 8, 2022

Added another nit to reuse some code @FSM1

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Feb 8, 2022
@Tbaut Tbaut enabled auto-merge (squash) February 8, 2022 14:09
@Tbaut Tbaut merged commit 54eaf78 into dev Feb 8, 2022
Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 All looking good now 👍

@Tbaut Tbaut deleted the fix/tbaut-errorMessage-1922 branch February 8, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Confirm plan change" error message persists on modal
4 participants